Fix 944 #967
Merged
Fix 944 #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
reviewed
Jul 14, 2020
|
I'm able to restore both keywords now. |
Smaug123
approved these changes
Jul 14, 2020
| |> updateTriviaNode (fun tn -> tn.ContentItself <- Some (Keyword(kw))) triviaNodes | ||
| |> updateTriviaNode (fun tn -> | ||
| match tn.Type, tn.ContentItself with | ||
| | MainNode ("SynMemberSig.Member"), Some (Keyword ({ Content = existingKeywordContent } as token)) when existingKeywordContent = |
There was a problem hiding this comment.
Oh my :P the actual content of the code looks fine to me, and I know it's entirely not my place to comment on code layout in a codebase I barely know, but a 120-space indent seems a bit much to me!
There was a problem hiding this comment.
Yeah, I know, but uh the thing is that I formatted it with Fantomas, so yeah 🙈.
I guess we can later use it as sample to improve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the problem we have with #944 is that the trivia detects two keywords and assigns them both to TriviaContentItSelf.
And so the last keyword (
memberin this case) wins.I've added a rather targeted workaround to avoid
abstractbeing replaced bymemberinSynMemberSig.Member.I think this will make your code compile again, however, in the future it would be nice to preserve both keywords.
This fix might suffice short term...